gnodet commented on PR #27173: URL: https://github.com/apache/camel/pull/27173#issuecomment-6101093030
**Addendum — wrong route IDs in `BatchConsumerReconnectTest`.** All three `triggerConnectionFailure(...)` calls use `ROUTE_ID_AUTO_ACK_NO_TX`, even in the session-transacted and client-ack test methods: ```java // testSessionTransacted() triggerConnectionFailure(context, ROUTE_ID_AUTO_ACK_NO_TX); // ← should be ROUTE_ID_SESSION_TX // testClientAcknowledge() triggerConnectionFailure(context, ROUTE_ID_AUTO_ACK_NO_TX); // ← should be ROUTE_ID_CLIENT_ACK_NO_TX ``` This means those two tests disconnect the auto-ack consumer and assert that the transacted/client-ack routes recovered — but since `triggerConnectionFailure` targets the wrong route, the reconnect behavior of the transacted and client-ack sessions is never exercised. The tests probably still pass (they observe the auto-ack route recovering), but they don't test what they claim to test. _This review was generated by an AI agent, Hermès on behalf of @gnodet._ <!-- reviewer: gnodet-bot --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
