ramu11 commented on code in PR #27686:
URL: https://github.com/apache/camel/pull/27686#discussion_r4241877441


##########
components/camel-kamelet/src/main/java/org/apache/camel/component/kamelet/Kamelet.java:
##########
@@ -230,6 +232,63 @@ public static RouteDefinition 
templateToRoute(RouteTemplateDefinition in, Map<St
             throw new IllegalArgumentException("Camel route " + rid + " input 
does not exist.");
         }
 
+        // Extract advanced options for source/sink component endpoints
+        Map<String, Object> sourceOptions = 
PropertiesHelper.extractProperties(parameters, "source.");
+        Map<String, Object> sinkOptions = 
PropertiesHelper.extractProperties(parameters, "sink.");
+
+        // Determine Kamelet type: source Kamelets have real component as 
input,
+        // sink/action Kamelets have kamelet:source as input and real 
component in outputs
+        boolean isSourceKamelet = 
!def.getInput().getEndpointUri().startsWith("kamelet:source")
+                && 
!def.getInput().getEndpointUri().startsWith("kamelet://source");

Review Comment:
   Thanks for the suggestion. I've updated the check to match the exact 
`kamelet:source` endpoint, including supported URI forms with query parameters, 
so similarly prefixed names aren't accidentally treated as source Kamelets.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to