apupier opened a new pull request, #27773:
URL: https://github.com/apache/camel/pull/27773
testRouteIdFailed intermittently failed with:
mock://result Received message count. Expected: <0> but was: <1>
Root cause: both tests used the same queue on the singleton Artemis broker,
which outlives the CamelContext of each test. testRouteId asserts on
mock:result from inside the JMS transaction, i.e. possibly before the session
commit has completed. When the context is torn down first, the commit loses the
race, the message is rolled back and stays on the queue. testRouteIdFailed then
starts a new context whose consumer receives the redelivered "Hello World",
which reaches mock:result and breaks expectedMessageCount(0).
How it was found:
- 20 sequential runs, plus 12 runs under CPU load, all passed, so the race
could not be hit with normal timing.
- Mock expectations are set per test (and tests run in order), so a stale
mock state was ruled out: the message had to be a real one.
- Simulating a slow commit (JmsTransactionManager.doCommit sleeping 1.5s)
reproduced the exact failure on the first run.
- Dumping mock:result's exchanges on failure showed body=Hello World,
JMSRedelivered=true, JMSXDeliveryCount=2, i.e. the message of the previous test.
Fix: use a distinct queue per test method so a message left over by one test
can no longer be consumed by the next one. With the slow-commit simulation the
fixed test passed 5/5 runs.
Co-authored-by: IBM Bob 2.2.1
# Description
<!--
- Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
# AI-assisted contributions
- [ ] If this PR includes AI-generated code, commits have proper
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR
description identifies the AI tool used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
