etzel-mes commented on code in PR #27780:
URL: https://github.com/apache/camel/pull/27780#discussion_r4258620163
##########
components/camel-milo/src/main/java/org/apache/camel/component/milo/client/MiloClientConsumer.java:
##########
@@ -54,9 +63,34 @@ public MiloClientEndpoint getEndpoint() {
@Override
protected void doStart() throws Exception {
super.doStart();
+ final Map<ExpandedNodeId, Consumer<DataValue>> valueConsumers = new
LinkedHashMap<>();
+ for (final String node : resolveNodes()) {
+ valueConsumers.put(ExpandedNodeId.parse(node), value ->
handleValueUpdate(node, value));
Review Comment:
Applied in 1152ffdf94c: the consumer now fails with `Invalid node ID: <id>`,
covered by `MonitorNodesTest.invalidNodeIdIsNamed`. Milo's own message only
says `invalid identifier type: x=`.
_Claude Code on behalf of etzel-mes_
##########
components/camel-milo/src/main/java/org/apache/camel/component/milo/MiloConstants.java:
##########
@@ -30,6 +30,9 @@ public final class MiloConstants {
@Metadata(label = "producer", description = "The \"await\" setting for
writes.", javaType = "Boolean",
applicableFor = SCHEME_CLIENT)
public static final String HEADER_AWAIT = "CamelMiloAwait";
+ @Metadata(label = "consumer", description = "The node ID of the value, as
configured in the node or nodes option.",
+ javaType = "String", applicableFor = SCHEME_CLIENT)
+ public static final String HEADER_NODE_ID = "CamelMiloNodeId";
Review Comment:
Applied in 1152ffdf94c with a shorter sentence, because `CamelMiloNodeIds`
lists the nodes that the producer reads rather than overriding node IDs: "Not
to be confused with CamelMiloNodeIds, the list of nodes that the producer
reads."
_Claude Code on behalf of etzel-mes_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
