oscerd commented on PR #27767: URL: https://github.com/apache/camel/pull/27767#issuecomment-6163696920
Pushed `56c20f06` addressing all review threads (also rebased onto current `main`, which absorbed the adjacent CAMEL-25408 doc edit): - Hardened `VertxMcpPrincipal.roles()` against non-array claim shapes — no more `ClassCastException`, and a malformed `roles`/`groups`/`realm_access` token no longer fails the call. Added unit tests. - Documented that roles come only from token claims (a basic-auth caller has none) and that only the Vert.x server populates these today; regenerated the catalog mirror; added a basic-auth `no-roles` integration test. - Javadoc precision on `name()`. On the roles integration test (gnodet-bot): positive extraction is covered comprehensively by `VertxMcpPrincipalTest`, and the stamping wiring is shared with the integration-tested name path. A positive *end-to-end* roles test needs a JWT/OIDC server (basic-auth structurally carries no roles), which is disproportionate here and fits better once a token-claim runtime is wired (the CAMEL-25406 follow-up). _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
