gnodet-bot commented on code in PR #27901:
URL: https://github.com/apache/camel/pull/27901#discussion_r4283139744
##########
AGENTS.md:
##########
@@ -131,7 +131,7 @@ When merging a PR, an agent MUST perform the following
steps **in order**:
1. **Derive the milestone from the target branch**:
- Read the `<version>` from the root `pom.xml` on the PR's **target
branch** (e.g., `main`,
`camel-4.18.x`).
- - Strip the `-SNAPSHOT` suffix to get the milestone name (e.g.,
`4.23.0-SNAPSHOT` → `4.23.0`).
+ - Strip the `-SNAPSHOT` suffix to get the milestone name (e.g.,
`4.24.0-SNAPSHOT` → `4.23.0`).
Review Comment:
⚠️ **Stale example:** The SNAPSHOT was bumped to `4.24.0-SNAPSHOT` but the
derived version in this example was left as `4.23.0`. AI agents reading these
guidelines after the merge will apply the wrong milestone.
```suggestion
- Strip the `-SNAPSHOT` suffix to get the milestone name (e.g.,
`4.24.0-SNAPSHOT` → `4.24.0`).
```
##########
.oss-ai-helper-rules/project-guidelines.md:
##########
@@ -18,7 +18,7 @@ This rule file contains branching, commit, PR, and
task-finding conventions for
- **Find-task experienced JQL:** `project = CAMEL AND status = Open AND labels
= help-wanted` (maxResults=10)
- **Scope-too-large redirect:** create a Jira issue directly
- **Merge procedure:**
- 1. Derive milestone from target branch: read `<version>` from root `pom.xml`
on the target branch and strip `-SNAPSHOT` (e.g., `4.23.0-SNAPSHOT` → `4.23.0`)
+ 1. Derive milestone from target branch: read `<version>` from root `pom.xml`
on the target branch and strip `-SNAPSHOT` (e.g., `4.24.0-SNAPSHOT` → `4.23.0`)
Review Comment:
⚠️ **Stale example:** Same issue — `4.24.0-SNAPSHOT` paired with `4.23.0`.
Should be `4.24.0`.
```suggestion
1. Derive milestone from target branch: read `<version>` from root
`pom.xml` on the target branch and strip `-SNAPSHOT` (e.g., `4.24.0-SNAPSHOT` →
`4.24.0`)
```
##########
dsl/camel-jbang/camel-jbang-mcp/src/test/java/org/apache/camel/dsl/jbang/core/commands/mcp/ConfigurationValidateToolsTest.java:
##########
@@ -59,7 +59,7 @@ void validatesValidMainProperty() {
@Test
void theRunningVersionWithoutSnapshotIsTheDefaultCatalog() {
- // an assistant that reads "4.23.0-SNAPSHOT" from the server asks for
4.23.0, which is not on Maven Central
+ // an assistant that reads "4.24.0-SNAPSHOT" from the server asks for
4.23.0, which is not on Maven Central
Review Comment:
💡 **Stale comment:** Says `asks for 4.23.0` — after the bump, the stripped
SNAPSHOT version is `4.24.0`.
```suggestion
// an assistant that reads "4.24.0-SNAPSHOT" from the server asks
for 4.24.0, which is not on Maven Central
```
##########
dsl/camel-jbang/camel-jbang-mcp/src/main/java/org/apache/camel/dsl/jbang/core/commands/mcp/CatalogService.java:
##########
@@ -84,7 +84,7 @@ public CamelCatalog loadCatalog(String runtime, String
camelVersion, String plat
boolean hasVersion = camelVersion != null && !camelVersion.isBlank()
&& !camelVersion.isEmpty()
&& Character.isDigit(camelVersion.trim().charAt(0));
if (hasVersion && sameAsDefault(camelVersion)) {
- // the version in use (4.23.0 for a 4.23.0-SNAPSHOT build):
nothing to download
+ // the version in use (4.23.0 for a 4.24.0-SNAPSHOT build):
nothing to download
Review Comment:
💡 **Stale comment:** The comment says `4.23.0 for a 4.24.0-SNAPSHOT build` —
the stripped version should now be `4.24.0`.
```suggestion
// the version in use (4.24.0 for a 4.24.0-SNAPSHOT build):
nothing to download
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
