Croway commented on PR #132:
URL:
https://github.com/apache/camel-upgrade-recipes/pull/132#issuecomment-6166512918
Thanks for the review, every point checked out against the sources.
Addressed in e29f273 and c6dcbe8:
- **langchain4j-tools gate**: confirmed in rewrite-core that `rewrite:run`
stops after one cycle unless a recipe sets `causesAnotherCycle`, and that
`ModuleHasDependency` decides from the scan phase. The removal is now gated on
`camel-langchain4j-tools`, the chain test runs with the default cycle count,
and the release-notes rationale is rewritten.
- **`ircHeadersMigrationJava`**: guarded with `@DisabledIfSystemProperty`,
as in `CamelUpdate419Test`.
- **`doesNotSwapAiToolInNonBootModule`**: now expects the plain
`camel-ai-tool` bumped to 4.23.0.
- **Spring versions**: 4.1.1 / 7.0.9 / 7.1.1 / 6.0.5, taken from the Camel
parent pom at `camel-4.23.0`.
- **debezium-oracle Endpoint DSL and Component DSL**, **ibm-cos
`iBMCOSContentControl()`**: both migrated with `ChangeMethodName`; the 4.22
endpointdsl and componentdsl jars are on the test classpath.
- **`language:csimple?script=` / bare `language:joor`**: covered; the
`camel.language.csimple.*` / `camel.language.joor.*` keys are documented as
manual since the replacement languages do not share their options.
- **Negative tests** for jolt, chunk, debezium-oracle and the joor XML
element added.
- **`bean(...).joor(...)`**: rewritten around
`routeTemplate("t").templateBean("b").joor(...)`, the one DSL entry that
returns a `BeanFactoryDefinition`.
- **pqc star import**: four imports per file, the fifth class lives in a
second source.
- **Duplicate-starter test**: input now carries the plain `camel-ai-tool`.
- **Patch namespaces**: yes, and it went further than pqc and
mustache/chunk. Checked against the `camel-4.18.x` and `camel-4.22.x` branch
sources (the guide copies on those branches lag behind `main`): pqc now lives
in `camel422_2`, mustache/chunk in `camel418_5` (also shipped in the released
4.18.5), and the 4.22 atmosphere-websocket rename in `camel418_4`, since it
shipped in 4.18.4 as well. The 4.22, 4.23 and both 4.18 LTS chains reference
them, and the LTS target is 4.18.5.
The LATEST suite is green against the staging repositories; the remaining
runs are listed in the PR description.
_Claude Code on behalf of croway_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
