apupier opened a new pull request, #27902: URL: https://github.com/apache/camel/pull/27902
Awaitility The test shouldAwaitCreationAndGetDataNotification fires 5 ZooKeeper mutations in sequence and expects the mock endpoint to receive exactly 5 messages (1 NodeCreated + 4 NodeChildrenChanged). The consumer uses a single-threaded OperationsExecutor: after each ChildrenChangedOperation fires it must synchronously call getChildren() in getResult(), deliver the exchange to the processor, then re-enqueue a copy of itself via createCopy(), and finally call installWatch() on the new copy to re-register the ZooKeeper watcher before the next event can be captured. The original test relied on a 200 ms pre-delay in TestZookeeperClient (delay(200) fires before the ZooKeeper mutation, not after). On a slow or loaded machine this is not long enough for the consumer to finish processing + re-registering the watch before the next mutation fires, causing a ZooKeeper NodeChildrenChanged event to be silently dropped. The mock then receives 4 instead of 5 messages. Fix: use Awaitility after each mutation to wait until the mock has actually received the corresponding message before triggering the next one. This guarantees the watch is re-registered before the next event fires, making the sequencing deterministic regardless of machine speed. Also rename the ZooKeeper node from /grimm to /grimm-ConsumeChildrenIT to isolate this test from any other test that might share the same ZooKeeper server, consistent with the same fix already applied to ConsumeDataIT and the cluster integration tests. Co-authored-by: IBM Bob 2.2.1 # Description <!-- - Write a pull request description that is detailed enough to understand what the pull request does, how, and why. --> # Target - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> # AI-assisted contributions - [ ] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
