ammachado commented on PR #26921:
URL: https://github.com/apache/camel/pull/26921#issuecomment-6256659814
Thanks @davsclaus, agreed that the half-and-half state is the worst of both.
I went with option 2: the list stays the only form of `beans:`, and the PR is
now only about the messages.
What changed (rebased on main, force-pushed):
- The map form is no longer accepted. `mapKey`, the schema `oneOf`, the map
reading in `BeansDeserializer`, the `BeanRefChecks` map scanning, the docs NOTE
and the upgrade-guide entry are gone.
- `camel run` now fails on both shapes with the list form to write, instead
of `Node type map is invalid, expected array` / `Unsupported field: myBean`. It
uses the validator's existing wording, so `camel run` and `camel validate` say
the same thing. This applies to the top-level `beans` and to those of
`routeTemplate` and `templatedRoute`.
- The validator's bean item hints matched only the top-level `beans`
(`/\d+/beans/\d+` in full). They now also cover `routeTemplate` and
`templatedRoute`.
On the inline threads: the hints now teach only the list form (no `myBean:
{type: ...}` alternative anywhere). The `MAP_KEY_PATTERN` flow-form gap and the
"name instead of" wording for map-form beans no longer apply, since neither the
map scanning nor the widened map-form hint is in the PR anymore.
I kept the map-form implementation on a local branch. If the project later
decides on option 1 through the dev list, it is a starting point for that, and
for the other name-keyed lists.
_Claude Code on behalf of Adriano Machado (@ammachado)_
_This was generated by an AI agent and may contain inaccuracies. Please
verify before relying on it._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
