apupier opened a new pull request, #28114:
URL: https://github.com/apache/camel/pull/28114
Two bugs combined to cause intermittent failures when MasterEndpointIT ran
before MasterQuartzEndpointIT in the same JVM.
1. Both Spring context XMLs started their own ZooKeeperContainer bean,
completely ignoring the @RegisterExtension ZooKeeperService. That service's
container was never used. The Spring-owned container also configured
CuratorFactoryBean with a 3000ms connection timeout, too short under CI load.
Fix: remove the zkContainer/zkConnectString beans from both XMLs, add
PropertySourcesPlaceholderConfigurer, and read the connection string from the
${zookeeper.connection.string} system property that
ZooKeeperLocalContainerInfraService.registerProperties() already sets when the
@RegisterExtension service starts. Raise the curator connection timeout to
30000ms.
2. Both context XMLs used the same ZooKeeper election path
(zookeeper-master:master-000:...). Because @CamelSpringTest caches Spring
contexts, the first test kept its CamelContext alive while the second test ran.
The cached context held the master-000 lease, so the second test could never
win the election within the 30s Awaitility window.
Fix: give each test a distinct group name (master-endpoint-it and
master-quartz-it) so they never compete for the same ZK path.
Co-authored-by: IBM Bob 2.2.1
# Description
<!--
- Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
# AI-assisted contributions
- [ ] If this PR includes AI-generated code, commits have proper
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR
description identifies the AI tool used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
