davsclaus commented on code in PR #28045:
URL: https://github.com/apache/camel/pull/28045#discussion_r4318288502
##########
components/camel-milo/src/main/java/org/apache/camel/component/milo/client/internal/SubscriptionManager.java:
##########
@@ -445,14 +437,24 @@ public void dispose() {
}
}
+ /**
+ * @return the node ID with the namespace index of the server,
completed with null if its namespace URI is not
+ * in the namespace table of the server: such a node does not
exist on the server
+ */
private CompletableFuture<NodeId> lookupNamespace(final ExpandedNodeId
nodeId) {
LOG.trace("Expanded Node Id: {}", nodeId);
final String uri = nodeId.getNamespaceUri();
if (uri != null) {
LOG.trace("Looking up namespace: {}", uri);
- return lookupNamespaceIndex(uri).thenApply(index ->
toNodeId(index, nodeId));
+ return lookupNamespaceIndex(uri).thenApply(index -> {
+ if (index == null) {
Review Comment:
Resolving: this nit is optional and does not block the merge. A follow-up
can make `lookupNamespaceIndex` fail on a bad status if it turns up in practice.
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
