allthingssecurity commented on PR #28204: URL: https://github.com/apache/camel/pull/28204#issuecomment-6309067217
Thanks Claus. 1. Done in 3ac611e69d86: only an ephemeral consumer is created again. When a durable is found gone (409 or the consumer check), the consumer logs a WARN once and keeps the subscription, so the fetches work again when the durable is created again with the same name. The upgrade guide entry now covers the ephemeral consumer and says a durable is not created again. New test with a deleted durable: one WARN, no new consumer, messages again after it is created again. 2. Done in 3ac611e69d86: the empty-fetch path and the 409 path use one helper, which reports a failed subscribe through the exception handler and tries again at the next check instead of ending the loop. Test with a subscribe that throws `IllegalStateException` once. 3. Done in 3ac611e69d86: `.startTime(null)`. jnats leaves a null start time out of the request, so it is harmless in any case. I could not check the server side here. 4. Done in 3ac611e69d86: javadoc on `subscribeAgain`. 5. Done in 3ac611e69d86: the new subscription is unsubscribed if the route is stopping (the field is volatile now), the one-argument `DefaultNatsManualAck` constructor is removed, and the comment says what the code does. Unit tests: 10 run, 0 failures. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
