allthingssecurity commented on PR #28197: URL: https://github.com/apache/camel/pull/28197#issuecomment-6310219099
Thanks Claus. - `maxReconnectDelay` below one second: done in a1664124d947 with your `Math.max(min, ...)`. New test with `maxReconnectDelay=0`: without the floor the second attempt came after 429 ms, now after at least 1 s. The default is 128000, so the default case was fine. - Shared client: `MqttClient` does not expose the options it was connected with, so the consumer cannot check them, and leaving every failed QoS 1 message of a shared client unacknowledged would keep the stall for clean sessions. So the doc and the upgrade guide now say that with the `client` option the endpoint's `cleanStart` and `sessionExpiryInterval` must match the client's connection options. If you prefer that a shared client never acknowledges a failed QoS 1 message, that is a small change in `rollback`; happy to do it. - I'll file the two follow-up JIRAs (`sessionExpiryInterval` javadoc, `setCallback` after `connect`) and link them here. On the bot's points: the delay floor is the fix above (the default `maxReconnectDelay` is 128000, not 0). The minimum reconnect delay is not an endpoint option and Camel does not set it, so it is always Paho's one second; the doc keeps "one second". Backporting is up to the committers; the change comes with an upgrade-guide entry. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
