This is an automated email from the ASF dual-hosted git repository.
Croway pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-upgrade-recipes.git
The following commit(s) were added to refs/heads/main by this push:
new cd88b65 Shorten the CAMEL-24539 review comment added by the 4.22.1
openai recipes
cd88b65 is described below
commit cd88b652d58f0a8e57fc9c51f7c4646cef9c1dca
Author: croway <[email protected]>
AuthorDate: Mon Oct 19 11:26:47 2026 +0200
Shorten the CAMEL-24539 review comment added by the 4.22.1 openai recipes
The comment was 367 characters on a single line, the longest any recipe
in this repository emits, and in the Java DSL it is rendered inside the
call argument. Keep the JIRA key, the condition and the new property
names, drop the rest: 218 characters.
---
.../FlagOpenAIFullResponsePropertyInJavaDsl.java | 6 ++---
.../apache/camel/upgrade/CamelUpdate422_1Test.java | 30 +++++++++++-----------
2 files changed, 17 insertions(+), 19 deletions(-)
diff --git
a/camel-upgrade-recipes/src/main/java/org/apache/camel/upgrade/camel422_1/FlagOpenAIFullResponsePropertyInJavaDsl.java
b/camel-upgrade-recipes/src/main/java/org/apache/camel/upgrade/camel422_1/FlagOpenAIFullResponsePropertyInJavaDsl.java
index e7daf61..87ba63b 100644
---
a/camel-upgrade-recipes/src/main/java/org/apache/camel/upgrade/camel422_1/FlagOpenAIFullResponsePropertyInJavaDsl.java
+++
b/camel-upgrade-recipes/src/main/java/org/apache/camel/upgrade/camel422_1/FlagOpenAIFullResponsePropertyInJavaDsl.java
@@ -45,10 +45,8 @@ import java.util.regex.Pattern;
public class FlagOpenAIFullResponsePropertyInJavaDsl extends Recipe {
static final String WARNING_COMMENT
- = " CAMEL-24539 (Camel 4.22.1): with storeFullResponse=true,
embeddings/audio-transcription/audio-translation "
- + "now use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
"
- + "instead of CamelOpenAIResponse; chat-completion is unchanged.
Verify which operation this refers to and update "
- + "the property name manually if needed.";
+ = " CAMEL-24539: with storeFullResponse=true, embeddings and audio
operations now store the full response under "
+ + "CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response
instead of CamelOpenAIResponse; review this usage.";
@Override
public String getDisplayName() {
diff --git
a/camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate422_1Test.java
b/camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate422_1Test.java
index 16c2151..5394c9b 100644
---
a/camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate422_1Test.java
+++
b/camel-upgrade-recipes/src/test/java/org/apache/camel/upgrade/CamelUpdate422_1Test.java
@@ -81,13 +81,13 @@ public class CamelUpdate422_1Test implements RewriteTest {
from("direct:openai")
.setProperty("CamelOpenAIResponseModel",
constant("keep-model"))
.process(exchange -> {
- Object response =
exchange.getProperty(/* CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if
needed.*/"CamelOpenAIResponse", Object.class);
- exchange.setProperty(/* CAMEL-24539
(Camel 4.22.1): with storeFullResponse=true,
embeddings/audio-transcription/audio-translation now use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if
needed.*/"CamelOpenAIResponse", response);
+ Object response =
exchange.getProperty(/* CAMEL-24539: with storeFullResponse=true, embeddings
and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.*/"CamelOpenAIResponse", Object.class);
+ exchange.setProperty(/* CAMEL-24539:
with storeFullResponse=true, embeddings and audio operations now store the full
response under CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response
instead of CamelOpenAIResponse; review this usage.*/"CamelOpenAIResponse",
response);
})
- .setProperty(/* CAMEL-24539 (Camel
4.22.1): with storeFullResponse=true,
embeddings/audio-transcription/audio-translation now use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if
needed.*/OpenAIConstants.RESPONSE, exchangeProperty(/* CAMEL-24539 (Camel
4.22.1) [...]
- .setBody(simple(/* CAMEL-24539 (Camel
4.22.1): with storeFullResponse=true,
embeddings/audio-transcription/audio-translation now use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if
needed.*/"${exchangeProperty.CamelOpenAIResponse.data}"))
+ .setProperty(/* CAMEL-24539: with
storeFullResponse=true, embeddings and audio operations now store the full
response under CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response
instead of CamelOpenAIResponse; review this usage.*/OpenAIConstants.RESPONSE,
exchangeProperty(/* CAMEL-24539: with storeFullResponse=true, embeddings and
audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead [...]
+ .setBody(simple(/* CAMEL-24539: with
storeFullResponse=true, embeddings and audio operations now store the full
response under CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response
instead of CamelOpenAIResponse; review this
usage.*/"${exchangeProperty.CamelOpenAIResponse.data}"))
.removeProperty("CamelOpenAIResponseId")
- .removeProperty(/* CAMEL-24539 (Camel
4.22.1): with storeFullResponse=true,
embeddings/audio-transcription/audio-translation now use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if
needed.*/"CamelOpenAIResponse");
+ .removeProperty(/* CAMEL-24539: with
storeFullResponse=true, embeddings and audio operations now store the full
response under CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response
instead of CamelOpenAIResponse; review this usage.*/"CamelOpenAIResponse");
}
}
"""
@@ -157,7 +157,7 @@ public class CamelUpdate422_1Test implements RewriteTest {
class Test extends RouteBuilder {
public void configure() {
from("direct:openai")
- .setProperty(/* CAMEL-24539 (Camel
4.22.1): with storeFullResponse=true,
embeddings/audio-transcription/audio-translation now use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if
needed.*/"CamelOpenAIResponse", exchangeProperty(/* CAMEL-24539 (Camel 4.22.1):
w [...]
+ .setProperty(/* CAMEL-24539: with
storeFullResponse=true, embeddings and audio operations now store the full
response under CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response
instead of CamelOpenAIResponse; review this usage.*/"CamelOpenAIResponse",
exchangeProperty(/* CAMEL-24539: with storeFullResponse=true, embeddings and
audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of [...]
}
}
"""
@@ -197,12 +197,12 @@ public class CamelUpdate422_1Test implements RewriteTest {
name: CamelOpenAIResponseModel
constant: keep-model
- setProperty:
- # CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if needed.
+ # CAMEL-24539: with storeFullResponse=true,
embeddings and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.
name: CamelOpenAIResponse
- # CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if needed.
+ # CAMEL-24539: with storeFullResponse=true,
embeddings and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.
simple:
"${exchangeProperty.CamelOpenAIResponse}"
- setBody:
- # CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if needed.
+ # CAMEL-24539: with storeFullResponse=true,
embeddings and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.
simple:
"${exchangeProperty.CamelOpenAIResponse.data}"
"""
)
@@ -224,9 +224,9 @@ public class CamelUpdate422_1Test implements RewriteTest {
uri: "direct:openai"
steps:
- setProperty:
- # CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if needed.
+ # CAMEL-24539: with storeFullResponse=true,
embeddings and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.
name: CamelOpenAIResponse
- # CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if needed.
+ # CAMEL-24539: with storeFullResponse=true,
embeddings and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.
simple:
"${exchangeProperty.CamelOpenAIResponse}"
"""
)
@@ -259,9 +259,9 @@ public class CamelUpdate422_1Test implements RewriteTest {
<setProperty name="CamelOpenAIResponseModel">
<constant>keep-model</constant>
</setProperty>
- <!-- CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if needed.-->
+ <!-- CAMEL-24539: with storeFullResponse=true,
embeddings and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.-->
<setProperty name="CamelOpenAIResponse">
- <!-- CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if needed.-->
+ <!-- CAMEL-24539: with storeFullResponse=true,
embeddings and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.-->
<simple>${exchangeProperty.CamelOpenAIResponse}</simple>
</setProperty>
</route>
@@ -282,9 +282,9 @@ public class CamelUpdate422_1Test implements RewriteTest {
"""
<route xmlns="http://camel.apache.org/schema/spring";>
<from uri="direct:openai"/>
- <!-- CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if needed.-->
+ <!-- CAMEL-24539: with storeFullResponse=true,
embeddings and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.-->
<setProperty name="CamelOpenAIResponse">
- <!-- CAMEL-24539 (Camel 4.22.1): with
storeFullResponse=true, embeddings/audio-transcription/audio-translation now
use
CamelOpenAIEmbeddingsResponse/CamelOpenAIAudioTranscriptionResponse/CamelOpenAIAudioTranslationResponse
instead of CamelOpenAIResponse; chat-completion is unchanged. Verify which
operation this refers to and update the property name manually if needed.-->
+ <!-- CAMEL-24539: with storeFullResponse=true,
embeddings and audio operations now store the full response under
CamelOpenAIEmbeddingsResponse or CamelOpenAIAudio*Response instead of
CamelOpenAIResponse; review this usage.-->
<simple>${exchangeProperty.CamelOpenAIResponse}</simple>
</setProperty>
</route>
