gnodet-bot commented on code in PR #28213:
URL: https://github.com/apache/camel/pull/28213#discussion_r4334715522
##########
core/camel-console/src/main/java/org/apache/camel/impl/console/RouteDevConsole.java:
##########
@@ -97,6 +97,8 @@ public record RouteEntry(
@Metadata(description = "Whether the endpoint is remote") boolean
remote,
@Metadata(description = "The source location (only present when
known)") String source,
@Metadata(description = "The source that declares the templated
route the route was created from (only present when known)") String
templatedRouteSource,
+ @Metadata(description = "The checksum of the route as written, the
same in every run: compare it with an earlier run to tell whether the route
changed (only present when known, as it needs camel-xml-io)") String checksum,
+ @Metadata(description = "The revision of the route in this run: 1
when it is added, one more each time it is added again changed, such as by a
reload (only present when the checksum is known)") Integer revision,
Review Comment:
💡 **Grammar nit:** The phrase `"added again changed"` is awkward. The
Route.java Javadoc uses `"added again with another checksum"` which reads
naturally — the same phrasing appears in 5 places (`RouteDevConsole.java`,
`ManagedRouteMBean.java`, and the two JSON schemas). Suggest aligning them:
```suggestion
@Metadata(description = "The revision of the route in this run:
1 when it is added, one more each time it is added again with another checksum,
such as by a reload (only present when the checksum is known)") Integer
revision,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
