davsclaus commented on PR #28211:
URL: https://github.com/apache/camel/pull/28211#issuecomment-6311814609
@oscerd thanks for the review. All four points are in 0efdc4989f33.
1. **Blocker, hint on other components:** done. The request-reply hint is
given only when the closest header is `JMSReplyTo`, and appends the hint text
itself (no `intentHint`). The `Reply` entry is out of `INTENT_HINTS`; a `Reply`
name with nothing close gets the JMS hint only when the file's components set
`JMSReplyTo`. New test `aReplyHeaderOfAnotherComponentGetsDidYouMean`: on an
ftp route `${header.CamelFtpReplycode}` still gets "did you mean
CamelFtpReplyCode?". The JMS test stays.
2. **Docs wording:** done. Both places now say "You do not need to set
`replyTo` or a `JMSReplyTo` header: Camel uses a temporary reply queue by
default. Set `replyTo` for a fixed (shared or exclusive) reply queue". The hint
says "you do not need to set JMSReplyTo or replyTo yourself".
3. **setExchangePattern vs pattern:** added a NOTE below the example. There
is no `toV` overload that takes a pattern, so the Java tab cannot keep
`variableReceive` and use `to(ExchangePattern.InOut, ...)`. The note says that
`setExchangePattern` keeps InOut for the rest of the route, and that for a
later `to("jms:...")` you set it back or use `to(ExchangePattern.InOut,
"jms:...")`.
4. **REPLY_NAME placement:** moved above the `INTENT_HINTS` javadoc, with
its own one-line javadoc.
Tests: `SourceValidator*Test` (172) and `ChecksCatalogDriftTest` (2) pass.
The catalog copy of the page is the same as the page.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
