gnodet-bot commented on code in PR #28183:
URL: https://github.com/apache/camel/pull/28183#discussion_r4335000628
##########
core/camel-core-model/src/main/java/org/apache/camel/model/rest/OpenApiDefinition.java:
##########
@@ -62,6 +62,10 @@ public class OpenApiDefinition extends
OptionalIdentifiedDefinition<OpenApiDefin
@Metadata(description = "Used for inclusive filtering of mock data from
directories. The pattern is using Ant-path style pattern. Multiple patterns can
be specified separated by comma.",
label = "advanced", defaultValue = "classpath:camel-mock/**")
private String mockIncludePattern;
+ @XmlAttribute
+ @Metadata(description = "Which external references ($ref) the OpenAPI
specification may use: all allows any reference, local allows references to the
classpath and the file system only, and none allows only references inside the
document. A reference the option does not allow fails the start.",
+ enums = "all,local,none", defaultValue = "all")
Review Comment:
💡 **Missing `label="security"` in `@Metadata`** — the component and endpoint
both declare this option with `label = "security"`, which places it in the
`"security"` group in the Camel catalog (and tooling such as Kaoto).
`OpenApiDefinition` is missing the label, so the generated `openApi.json`
currently shows `"group": "common"` for `externalReferences`. Since this option
is the security control for external reference resolution, the grouping should
be consistent.
```suggestion
@Metadata(description = "Which external references ($ref) the OpenAPI
specification may use: all allows any reference, local allows references to the
classpath and the file system only, and none allows only references inside the
document. A reference the option does not allow fails the start.",
label = "security", enums = "all,local,none", defaultValue =
"all")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
