oscerd opened a new pull request, #28236:
URL: https://github.com/apache/camel/pull/28236
## Backport of #28154
Port of #28154 (squash 3c848184a78d) onto `camel-4.18.x`.
**Original PR:** #28154 - CAMEL-25459, CAMEL-25460, CAMEL-25461:
camel-thrift - apply the SSL settings of the consumer and mute its exceptions
**Original author:** @oscerd
**Target branch:** `camel-4.18.x`
Not a straight cherry-pick, so reviewers are requested. On this branch the
synchronous `ThriftMethodHandler` does not
send the exception of a failed exchange to the client (CAMEL-25247 is on
`main` only), so:
- `ThriftMethodHandler`: `muteException` applies to the asynchronous server
only; the rest of the handler is the
branch's own (CAMEL-25247 is not brought over).
- `ThriftConsumerMuteExceptionTest` keeps the asynchronous cases (muted, not
muted, declared exception) and drops the
synchronous ones.
- `thrift-component.adoc`: "Errors sent to the client" says that this
applies to the asynchronous consumer.
- Everything else (SSL with `synchronous=false` and SASL failing at startup,
the SSL consumer built from
`sslParameters.createSSLContext()`, the `muteException` option, the tests)
is as in #28154, with the tests on the
junit5 `CamelTestSupport` of this branch. `ThriftConsumer` has no
`getLocalPort()` on this branch, so
`ThriftConsumerClientAuthenticationTest` and
`ThriftConsumerMuteExceptionTest` bind their routes to
`AvailablePortFinder.getNextAvailable()` ports, as the other thrift tests
of this branch do. There is no catalog copy
of the component doc on this branch. The upgrade-guide note for 4.18.6
already lives on `main`.
Build: full reactor `mvn clean install -DskipTests -DskipITs` on the branch:
BUILD SUCCESS (657/657 modules), no uncommitted generated changes;
`camel-thrift` tests: 49/49 (`ThriftConsumerMuteExceptionTest` 3/3,
`ThriftConsumerClientAuthenticationTest` 2/2,
`ThriftNegotiationTypeStartupTest` 3/3, `ThriftConsumerSecurityTest` 2/2).
Without the `ThriftMethodHandler` change, `asyncServerMutesTheException` fails
with `expected: <Internal error processing add> but was: <Detail of the
failure>`.
JIRA: https://issues.apache.org/jira/browse/CAMEL-25459,
https://issues.apache.org/jira/browse/CAMEL-25460,
https://issues.apache.org/jira/browse/CAMEL-25461
_Claude Code on behalf of Andrea Cosentino (@oscerd)_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
