allthingssecurity commented on PR #28203: URL: https://github.com/apache/camel/pull/28203#issuecomment-6313247331
Thanks Andrea. 1. Done in 5576a02d117b: `testAConfiguredInitialSequenceIdOfZeroIsUsed` (`initialSequenceId=0`). With `> 0` instead of `>= 0` it fails with `expected: <0> but was: <null>`. 2. Done in the same commit for the first part: the component page now says that with `initialSequenceId` set every start begins after that value again, so with a `producerName` and deduplication the broker drops the messages until they pass its last sequence id, and that leaving it unset lets the client continue. I left out the sentence about the -1 ledger and entry ids of a duplicate's message id: I could not check it against the client here, and I'd rather not document it without that. Happy to add it if you are sure of it. 3. Backports: up to the committers. 4.22.x and 4.18.x have the same `-1` default and the same client check, so the fix applies there too; if you want them, I'll add the matching notes to the 4.22 and 4.18 upgrade guides on main. I also updated the description: CI ran the ITs, and the option description was regenerated into the JSON and the DSL. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
