etzel-mes commented on PR #28212:
URL: https://github.com/apache/camel/pull/28212#issuecomment-6314190540

   Thanks for the review, Andrea.
   
   1. Confirmed and fixed in c68d3a1c9f7. A node is now marked as refused under 
`lock`, and its refusal is delivered only while that still holds, so a refusal 
that the creation of its item has overtaken is dropped, whether an attempt or a 
new connection created it. The marking happens at the end of 
`putSubscriptions`, once the call has succeeded, rather than in 
`Connected.refuse()`: a call that fails after refusing a node discards the 
refusal, and the node then still needs the loss report of the connection. The 
new test `refusalOvertakenByTheNextAttemptIsNotDelivered` holds the delivery of 
one node's refusal in the route until the next attempt has created the other 
node. On c92824359d3 the route then received the other node's refusal after its 
first value; with the fix it receives only the value.
   
   2. Agreed. #28219 (CAMEL-25873) makes `reconnectTimeout` set this interval; 
whichever of the two PRs is merged second will set it in these tests and 
shorten their waits.
   
   @davsclaus the two follow-ups are CAMEL-25912 for the producers not taking 
`lock`, linked to CAMEL-25694, and CAMEL-25913 for the dev console.
   
   _Claude Code on behalf of etzel-mes_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to