apupier opened a new pull request, #28244:
URL: https://github.com/apache/camel/pull/28244
The SMPP simulator thread was started in @BeforeAll but there was no
synchronisation before the Camel context (and its SMPP route) started in
@BeforeEach. On a slow or loaded CI node the route's connect attempt raced the
server's ServerSocket.bind(), producing:
FailedToStartRouteException: java.io.IOException: Connection refused
Fix:
- Override doPreSetup() (called before CamelTestSupport.setUp() creates the
context) and use Awaitility to poll until a TCP connection to the simulator
port succeeds, up to 30 s.
- Create the simulator Thread inside @BeforeAll (rather than as a
static-final field initialised at class-load time) so PORT is already resolved
— the same pattern used by SmppTRXProducerSupervisingRouteControllerIT.
- Mark the thread as a daemon so the JVM does not hang when a test failure
prevents @AfterAll from running.
- Guard the interrupt() call in @AfterAll with a null check.
# Description
<!--
- Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other
small items do not require a JIRA issue. In this case your pull request should
address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful
subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX]
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the
appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build
auto-formats your code. This will also be verified as part of the checks and
your PR may be rejected if if there are uncommited changes after running `mvn
clean install -DskipTests`.
You can learn more about the contribution guidelines at
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
# AI-assisted contributions
- [ ] If this PR includes AI-generated code, commits have proper
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR
description identifies the AI tool used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
