etzel-mes opened a new pull request, #28252: URL: https://github.com/apache/camel/pull/28252
# Description The `milo-client` and `milo-browse` components create the configuration of each endpoint with the copy constructor of `MiloClientConfiguration`, which did not copy `sessionTimeout` (since the first version of the class). A session timeout configured on the component, for example `camel.component.milo-client.sessionTimeout=30000`, therefore never reached an endpoint, and its sessions used the Milo default of 120000 ms. Only the endpoint option worked. `sessionTimeout` was the only field the copy constructor left out. This copies it. A `sessionTimeout` set on the endpoint still wins over the component's. Tests: `SessionTimeoutConfigurationTest`, for both components: the component value reaches the endpoint, and the endpoint option overrides it. Both tests fail without the fix with `expected: <30000> but was: <null>`. Docs: the 4.24 upgrade note. The option is already documented as a component option, so nothing is generated. Fixes CAMEL-25875. @davsclaus @oscerd # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. # AI-assisted contributions - [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. _Claude Code on behalf of etzel-mes_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
