davsclaus commented on code in PR #27956:
URL: https://github.com/apache/camel/pull/27956#discussion_r4357670308
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc:
##########
@@ -2366,6 +2366,16 @@ To keep the previous behaviour, filter the exchanges
with a bad status out right
`filter(simple("${body.statusCode.bad} == false"))`. This also drops the other
bad statuses, such as the refusal of a
node, and the current values delivered after an outage still arrive.
+=== camel-milo - an awaited write, call or read that fails now fails the
exchange
+
+An awaited `milo-client` write, method call or read whose server-side
operation fails, for example a write
+of a wrong type or a call that times out, now fails the exchange and lets the
route's error handler run.
+Before, the exchange completed without an error and with a `null` body,
silently discarding the failure.
Review Comment:
A write of a wrong type does not fail the exchange. `writeValuesAsync`
answers it with a per-node `Bad_TypeMismatch` `StatusCode`, so the future
completes normally and the `StatusCode` is the body, before and after this
change. The JIRA asks to keep that per-node behaviour. Only service or
transport failures (a `Bad_Timeout` service fault, a closed session, a lost
connection) complete the future exceptionally. Maybe:
```suggestion
An awaited `milo-client` write, method call or read that fails at the
service or transport level, for example a
request that times out (`Bad_Timeout`) or a lost connection, now fails the
exchange and lets the route's error
handler run. Before, the exchange completed without an error and with a
`null` body, silently discarding the failure.
A bad status for the node itself, such as `Bad_TypeMismatch` on a write, is
not a failure of the operation and is
still returned as the body.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
