allthingssecurity commented on PR #28324: URL: https://github.com/apache/camel/pull/28324#issuecomment-6361402877
@davsclaus thanks, addressed in 719b54734c7d: 1. Topic matching: `matches()` in `PahoMqtt5ClientCallback` and `PahoClientCallback` uses your split-level matcher; the Paho imports are gone. New `PahoMqtt5ClientCallbackMatchesTest` and `PahoClientCallbackMatchesTest` (34 cases each: MQTT 5 section 4.7 examples, empty levels, trailing `/`, `$` topics, `$share/g/...`), plus a routing test through `+/+` and `news/#` on one shared client in both `*SharedClientConsumersTest`. Without the change 9 matcher cases and the routing test fail in each module. 2. Stopped durable consumer of the same filter: documented in the upgrade-guide entry next to the overlapping-filter note. A fix would mean keeping a per-client record of filters left subscribed by stopped durable consumers that outlives the callback (it is removed when its last consumer stops), so I left it as a documented limitation. 3. Duplicate DEBUG log: removed from `PahoConsumer.onMessageArrived`. Tests (offline, unit tests, `-DskipITs`): camel-paho-mqtt5 68 run, 0 failures. camel-paho 70 run, 0 failures, 8 errors in `PahoComponentTest` (7) and `PahoManualAcksTest` (1): main has the same 8 on this machine (the broker's LAN address is not reachable here), and the new and shared-client tests pass. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
