allthingssecurity commented on PR #28319: URL: https://github.com/apache/camel/pull/28319#issuecomment-6361560250
@davsclaus thanks, addressed in two commits: 1. 6ae3e40c4d54: `TahuEdgeNodeProducer.doStop` uses `currentClient()`, as suggested. New test `clientIsShutDownWhenBothProducersOfTheEdgeNodeStopAfterOneWasRestarted` (two routes to one Edge Node endpoint, restart one, stop both: the second client publishes its NDEATH and is removed from the map). It fails without the change. 2. 2a4fbe20238a: a Device producer never creates the client. It takes its Edge Node's client from the map when it publishes, and fails the exchange with an `IllegalStateException` naming the Device and the Edge Node when no Edge Node producer is started. New test `deviceProducerCreatedWhileTheEdgeNodeIsStoppedUsesTheClientOfTheEdgeNode`; without the change the Device route fails to start with the NPE from `getDeviceIdList()`. Upgrade guide entry and one sentence in `tahu-edge-component.adoc` (and its catalog copy), since a send to a Device while its Edge Node is stopped now fails instead of being dropped. Not changed: stopping one of two Edge Node producers of the same Edge Node still shuts the client down for the other, as on main. I drafted a follow-up JIRA for counting the started Edge Node producers. Noted that `TahuEdgeProducer` is the same on camel-4.22.x and camel-4.18.x. Tests (offline, `-DskipITs`): `TahuEdgeProducerRestartTest` 5 run, 0 failures; camel-tahu unit tests 12 run, 0 failures. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
