allthingssecurity commented on PR #28318: URL: https://github.com/apache/camel/pull/28318#issuecomment-6363283108
@davsclaus on the optional nit (a stop and then a start in place while the first subscribe still runs, which leaves the old keeper listening): it goes into the drafted follow-up JIRA (the one for a consumer deleted while connected), not into this PR. That case only leaks a listener. The first run's executor is shut down, so its `connectionEvent` cannot submit a check (the rejection is swallowed), and the first run's subscription belongs to the dispatcher that the stop closed. So the route behaves the same, and I'd rather not restart CI here for it. The follow-up does what you suggest: the task also checks whether its own run's executor is shut down (or a per-run flag that `doStop` sets), next to `isRunAllowed()`. The same per-run check also covers the new DEBUG check in #28320. On CI: agreed. Whichever of #28318 and #28320 lands second should get a fresh CI run on top of the other before it is merged. Locally, #28320's head merged with this branch passes the camel-nats unit tests (22 run, 0 failures). _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
