davsclaus opened a new pull request, #28349: URL: https://github.com/apache/camel/pull/28349
Fixes [CAMEL-26093](https://issues.apache.org/jira/browse/CAMEL-26093), found while adding the catalog body types of the AWS components (#28343). **The bug.** `camel-aws-parameter-store` has been missing from the list of `camel-aws` modules in `MojoHelper.getComponentPath` since the component was added in 4.18.0 (CAMEL-22819). So the catalog had no `aws-parameter-store.json` and no page, and everything that reads the catalog missed the component: - `camel run` of a route with `aws-parameter-store:` failed with "cannot find component with name aws-parameter-store" unless the dependency was given by hand; - the Endpoint DSL and the component DSL had no builder for it; - the build checks of the doc examples never saw its page, since they read the pages in the catalog. CAMEL-17372 was the same problem for azure-servicebus. **The fix** - Registers the module in `MojoHelper`. - Adds what the catalog build generates for the component: - `aws-parameter-store.json` and its page in the catalog, and their entries in `components.properties` and `docs.properties`; - the artifact in `ArtifactUtils`, and the component as an owner of `trustAllCertificates` in `SecurityUtils` (camel-util); - the name in `components.properties` of camel-main; - the known dependency of camel-kamelet-main; - `ParameterStoreEndpointBuilderFactory` and `AwsParameterStoreComponentBuilderFactory`, and their entries in the aggregated builders of the endpoint and component DSL. - Fixes nine YAML examples of the page, which put `steps:` beside `from:` instead of under it, so those routes did not load. The generated files were produced by the generators of camel-package-maven-plugin, run one by one: the catalog helper goals, `prepare-kamelet-main`, and `generate-sources` of the two DSL modules. The catalog JSON and page are copies of the module's own, as `prepare-catalog` makes them; they are byte for byte the same for the other components. The diff has nothing but this component. **Tests**, run against a catalog jar with these files: - `EipDocExamplesTest` of camel-yaml-dsl-validator passes. With the page as it was, it fails on the nine examples: "required property 'steps' not found". - `CatalogDocsTest`, `CatalogDocExamplesTest` and `CatalogDocJavaExamplesTest` of camel-jbang-core pass (80 tests). - `DocExamplesXmlSchemaTest`, `DocExamplesJavaImportsTest` and `CamelCatalogTest` of camel-catalog pass (144 tests). The other items of CAMEL-26093 are not changed here: - no operation fails with a NullPointerException; - getParameters does not trim the names. _Claude Code on behalf of davsclaus_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
