allthingssecurity commented on PR #28320: URL: https://github.com/apache/camel/pull/28320#issuecomment-6362051159
@davsclaus thanks for the review. The optional point is done in 15aa72e0c6a5: the in-flight state now lives on the per-dispatcher `CamelNatsMessageHandler`, and each run closes its own dispatcher. New test `eachRunOfTheConsumerClosesItsOwnDispatcher` (the same consumer stopped and started in place, as a route policy does, while a message of the first run is in flight) fails without the change. The side effect you mention (the dispatcher of a core NATS consumer is now closed on stop with a shared connection) will be added to the description. Tests (offline, `-DskipITs`): `NatsConsumerJetStreamPushStopTest` 3 run, 0 failures; camel-nats unit tests 8 run, 0 failures. Merged locally with #28318: camel-nats 21 run, 0 failures. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
