allthingssecurity commented on PR #28383:
URL: https://github.com/apache/camel/pull/28383#issuecomment-6382441757
@davsclaus addressed in 3d832a0d46ea.
- **Docs:** I added a NOTE to the eips `keyValueRepository.adoc`, after the
existing NOTE in the KeyValueAggregationRepository section. The catalog copy is
updated the same way and is still identical. I also added it to
`key-value-repository.adoc` under "Single backend, multiple patterns". The NOTE
says:
- with a persistent store, set explicit route and aggregator ids, because
the generated ones can change when routes are added or reordered;
- when several aggregators use one `KeyValueRepository` through explicit
`KeyValueAggregationRepository` beans, create the beans with the `(repository,
recoveryName)` constructor and a different name for each aggregator.
- **Setter:** I did not add one. A `recoveryName` property would change the
generated metadata of the bean and need a regen. XML and YAML users can already
pass constructor arguments to a bean (`<constructors>` in XML, `constructors:`
in YAML), and most users get the name automatically through auto-discovery. If
you'd rather have the setter, I can add it with the regen in a follow-up.
- **Test:** `release.countDown()` now runs in an `@AfterEach`, so a failure
before it no longer keeps the shutdown waiting on the blocked exchange.
- **Nit `]:`:** the `@param recoveryName` javadoc now says the name should
not contain `]:`, with the `a]:b` / `a` example.
- **Related (`doStop` stops and clears the shared repository):** agreed. I
drafted it as a separate JIRA and will file it after writing a reproducing test.
Tests run:
- camel-support: 139 run, 0 failures.
- camel-core with camel-support and camel-core-processor of this branch in
the reactor, running `org.apache.camel.processor.aggregator.**`,
`org.apache.camel.support.**` and `*Aggregat*`: 764 run, 0 failures, 6 skipped.
This includes `AggregateAutoDiscoveredKeyValueRepositorySharedTest`,
`...RecoverTest` and `KeyValueAggregationRepositoryTest`.
- Not run: the whole camel-core suite.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
