allthingssecurity commented on PR #28382:
URL: https://github.com/apache/camel/pull/28382#issuecomment-6385790266
@davsclaus thanks for the review. Your 4 points are in 7d21f47b6987 (docs
and javadoc only, no code change):
- `test-dst.adoc` (and the byte-identical catalog copy):
`ConcurrentRequestsThrottler` added to the waits that are not virtual ("three
waits"), with its own bullet and the `alsoRewrite` hint for
`org.apache.camel.processor.ConcurrentRequestsThrottler`.
- `TimeSource` javadoc and the doc: the created time of `MonotonicClock`
follows `TimeSource`, so message-history times are virtual in a DST run.
- The `Thread.sleep` of the route `delayer` option
(`CamelInternalProcessor.DelayerAdvice`) is now a line in the not-virtual list
(real sleep on the loop thread; use the `delay` EIP in a world).
- Next to the "one run per JVM" limitation: a `CamelContext` left running in
the same fork by an earlier non-DST test would read virtual time too and could
fail a strict seed.
**Core run, as you asked.** Branch 7d21f47b6987 merged locally with current
`main` b418ab6acd42 (not pushed). All 27 modules of `core/pom.xml` with `-am`,
`test -DskipITs -Dmaven.test.failure.ignore=true`, default fork settings
(camel-core in parallel forks). BUILD SUCCESS, no failures, errors or flaky
reruns.
| core module | run | failures | errors | skipped |
|---|---:|---:|---:|---:|
| camel-util | 305 | 0 | 0 | 0 |
| camel-support | 140 | 0 | 0 | 0 |
| camel-xml-jaxp-util | 4 | 0 | 0 | 0 |
| camel-xml-io-util | 8 | 0 | 0 | 0 |
| camel-core-model | 11 | 0 | 0 | 0 |
| camel-xml-io | 437 | 0 | 0 | 2 |
| camel-xml-jaxp | 21 | 0 | 0 | 0 |
| camel-yaml-io | 191 | 0 | 0 | 0 |
| camel-core | 8271 | 0 | 0 | 45 |
| camel-management | 574 | 0 | 0 | 1 |
| camel-main | 306 | 0 | 0 | 0 |
| camel-core-xml | 1 | 0 | 0 | 0 |
| camel-java-io | 193 | 0 | 0 | 1 |
| camel-console | 259 | 0 | 0 | 0 |
camel-api, camel-core-catalog, camel-management-api, camel-base,
camel-base-engine, camel-cluster, camel-core-engine, camel-core-languages,
camel-core-processor, camel-core-reifier, camel-xml-jaxb, camel-health and
camel-core-all have no tests; they built. The `-am` modules (camel-bean,
camel-file, camel-rest, camel-test-junit6 and others) also passed.
Environment note: the run was offline, with dependency versions overridden
to the ones in the local repository (mvel2 2.5.4.Final instead of 2.6.0.Final
for the package plugin; jackson, httpclient, grpc, jsch, spring, asm likewise).
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
