ramu11 commented on PR #28354: URL: https://github.com/apache/camel/pull/28354#issuecomment-6389106180
Thanks for the detailed reviews. I pushed `6f6f85742bf3` with follow-up fixes and regression tests. The main changes are: - **OpenAI:** Added validation for `toolSearch=true` with `openai:responses` when `autoToolExecution=false`, preserved discoveries across the manual tool-execution loop, and made tool-search failures respect `toolExecutionErrorStrategy`. - **Session lifecycle:** Added bounded LRU retention with a 10,000-session cap and 30-minute idle expiry, lazy registration, explicit invalidation, and clock-controlled expiry tests instead of `Thread.sleep`. - **LangChain4j:** Added tool-embedding caching and batching for missing embeddings, removed method-wide synchronization around model calls, guarded the reserved synthetic tool name for MCP tools, and added validation for the unsupported `@CompensateFor` combination. - **Configuration and shared code:** Kept the endpoint `toolSearch` option authoritative, extracted shared argument parsing into `AiToolSearchArguments`, and synchronized index cache check/build/update in OpenAI and Spring AI. - **Ranking and documentation:** Added deterministic catalogue-order tie-breaking and documented the current vector-search behavior. I have retained top-N cosine-similarity ranking without a minimum vector-score threshold in this change; that behavior is now explicitly documented rather than having an implicit cutoff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
