TheNetherWatcher opened a new pull request, #6913:
URL: https://github.com/apache/camel-k/pull/6913

   _Claude Code on behalf of @TheNetherWatcher_
   
   Fixes #6912
   
   Adds a KEDA scaler mapping for RabbitMQ, following the [scaler mapping 
guide](https://camel.apache.org/camel-k/next/contributing/keda-scaler.html).
   
   **Component choice.** The plain `rabbitmq` component was removed in Camel 4 
in favour of `spring-rabbitmq` (Camel 4 migration guide, "Removed Components"), 
and the `spring-rabbitmq-source` Kamelet uses it too, so the mapper is 
registered for `spring-rabbitmq`.
   
   **Mapping.**
   - `spring-rabbitmq:<exchange>?queues=<queue>` maps to KEDA type `rabbitmq` 
with `queueName: <queue>`.
   - The URI path is the exchange, which the KEDA scaler doesn't use, so it is 
not mapped.
   - A KEDA rabbitmq trigger watches one queue, so when `queues` lists several, 
`queueName` is left unset for the user to pick via `keda.autoMetadata`.
   - The broker address lives on the Spring `connectionFactory` bean (and 
carries credentials), not in the URI, so `host`/`hostFromEnv`, `mode` and 
`value` are expected from `keda.autoMetadata` or a `TriggerAuthentication`. The 
trait docs say this.
   
   This uses the current `Map(pathValue, params)` signature. #6893 adds a 
`props` argument; if it merges first I'll rebase and add the extra parameter.
   
   **Tests.** `spring_rabbitmq_test.go` covers registration, 
single/no/empty/multiple queues, and `MapToKedaTrigger`. `go test 
./pkg/trait/keda/... ./pkg/trait` passes, and `golangci-lint` reports 0 issues 
on `pkg/trait/keda`. No API change, so `make generate` / `make update-docs` 
produce nothing for this change. Not tested against a live KEDA install.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to