Suhail98 opened a new pull request, #6918: URL: https://github.com/apache/camel-k/pull/6918
Fixes #6843 `RootCmdOptions` carries two contexts that now always hold the same value. `RootContext` used to keep the process alive while `kamel run --sync` cancelled and reran the command through `Context`. #6832 removed `--sync`, and since then `NewKamelCommand` sets both fields to the same `ctx`. Two names for one value leave readers guessing which to use. - Drop the `RootContext` field and its assignment in `NewKamelCommand`. - The wait point after `kamel run --logs` now blocks on `o.Context.Done()`. It was the only `RootContext` reader, and `kamel log` already waits the same way. No behaviour change: both fields held the same `ctx`, so the wait blocks on the same channel as before. The unit-test fixtures in `root_test.go` already set only `Context`. ## Testing `go build`, `go vet` (including the `integration`-tagged e2e packages) and `gofmt` are clean, and `golangci-lint` reports nothing in the touched files. `go test ./pkg/cmd/...` shows the same pre-existing Windows-only failures before and after the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
