allthingssecurity commented on PR #28434: URL: https://github.com/apache/camel/pull/28434#issuecomment-6409817883
@davsclaus thanks, added in 0c636fb28341 (a new commit on top). It changes only comments. - `FakeShareGroup`, the contract bullet where the wakeup rule is stated now adds: "This check relies on the stop not waiting for the processing lock (see the limits in KafkaShareWorld): with real threads, KafkaShareFetchRecords.stop() waits for that lock, and the consumer thread releases the rest of the batch before the wakeup." - `KafkaShareWorld` Javadoc, after the limit that a stop never waits for the processing lock: "The RELEASE check of the fake relies on this: with real threads, the stop waits for that lock, and the consumer thread releases the rest of the batch before the wakeup." The behaviour and the counts are unchanged. camel-kafka-share 1029 tests run (29, plus 1000 seeds), camel-kafka-common 11 and camel-test-dst 49, all with 0 failures. The formatter and import sort make no changes to the committed files. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
