Croway commented on PR #28357: URL: https://github.com/apache/camel/pull/28357#issuecomment-6412531144
Thanks @davsclaus and @oscerd. Rebased on main and pushed: - **Rejected consumer removing another consumer's route** (@davsclaus 1): `VertxWebsocketHost` now keeps the consumers that got as far as `connect`, and `disconnect(consumer)` does nothing for one that never connected, so the cleanup from `BaseService.start()` no longer removes the route on the same path or stops the server. The check runs before anything is registered, and a host newly created by `computeIfAbsent` always passes it, as it is built from that consumer's parameters. New test: a TLS route on `/same` is started, a second route without TLS on `/same` is started later through the route controller and fails, and a message sent over TLS to `/same` still reaches the first route. It fails without the fix. - **Upgrade guides** (@davsclaus 2): added the note under "Upgrading from 4.22.2 to 4.22.3" and "Upgrading from 4.18.5 to 4.18.6". - **Narrower API** (@oscerd 2): replaced `getHostConfiguration()` with `getSslContextParameters()` on the host. - **No parameters on either side** (@oscerd 3): new test showing that two consumers without `sslContextParameters` share one host and still receive messages. - **Instance identity** (@oscerd 1, @davsclaus 3): yes, that is the intended contract. It matches `NettyServerBootstrapConfiguration.compatible()`. `SSLContextParameters` has no `equals`, and comparing by content is not reliable because placeholders and resources are resolved lazily. Consumers that use the global SSL context parameters, or reference the same bean, share one instance. I'd handle checking `serverOptions` (which can also configure TLS) and `router` in a separate JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
