oscerd commented on PR #28553: URL: https://github.com/apache/camel/pull/28553#issuecomment-6437633825
Addressed all review feedback in commit 8f8c80a5b67: 1. **Mutual exclusion on SSE configuration**: Added explicit validation in `doPutObject` and `copyObject` throwing `IllegalArgumentException` if both `serverSideEncryption` and `serverSideEncryptionCustomerKey` are configured. 2. **Clean up `MinioChecks`**: Replaced all `MinioChecks` usages in `MinioProducer` with direct null checks, removing reliance on the deprecated utility. 3. **Dedicated tests**: Split `copyObjectWithEncryption` into distinct `copyObjectWithServerSideEncryption` and `copyObjectWithCustomerKey` tests, and added `putObjectWithBothEncryptionThrows` and `copyObjectWithBothEncryptionThrows` to assert validation behavior. 4. **Pre-fix verification**: Confirmed that `PutObjectArgs` builder produces an immutable object upon `build()`, and the test fails without the producer setting `sse(...)`. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
