oscerd commented on PR #28555: URL: https://github.com/apache/camel/pull/28555#issuecomment-6438423779
Thanks @davsclaus! Addressed the feedback in commit b92bcf25abc: 1. **Space normalisation**: Normalized `allowedTransports` in `CometdComponent` by splitting on commas, trimming each entry, filtering empties, and joining back with commas. Tested with spaced configuration in `CometdAllowedTransportsTest`. 2. **Upgrade guide wording**: Updated `camel-4x-upgrade-guide-4_24.adoc` to clarify that `long-polling` (and `websocket` when CometD WebSocket transport is on the classpath) is enabled by default. 3. **Option description**: Dropped redundant `description` attribute from `@UriParam` in `CometdEndpoint`, updated setter Javadoc to document allowed values, JSONP role, and server-level scoping. Added an "Allowed Transports and JSONP" section in `cometd-component.adoc` and synchronized the catalog copy. 4. **Test assertion**: Tightened the status code assertion in `testDefaultTransportsRejectsJsonp` to `assertEquals(400, response.statusCode())`. 5. **PR description**: Corrected the servlet init parameter name to `allowedTransports`. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
