gnodet commented on code in PR #28642: URL: https://github.com/apache/camel/pull/28642#discussion_r4409656942
########## components/camel-quartz/src/main/docs/quartz-component.adoc: ########## @@ -101,6 +101,17 @@ to keep running on the other nodes in the cluster. NOTE: When running in clustered node, no checking is done to ensure unique job name/group for endpoints. +=== Keeping the trigger when the route stops + +With `deleteJob=false` (also with `pauseJob=true`), the route keeps its trigger in the scheduler when it stops, and +pauses it. It marks the trigger as paused by Camel, with the key `CamelQuartzTriggerPausedByCamel` in the `JobDataMap` +of its job, so that a route with this trigger resumes it when it starts: the same route started again, a route that +was removed and added again, or the route after a restart of the application with a persistent job store. + +A trigger that was paused outside Camel (with the Quartz API or JMX, for example while the route runs) has no such +mark, and stays paused when the route starts, also when the same route is stopped and started again. A pre-configured trigger that you reuse with the Camel URI is resumed Review Comment: Run-on line — the sentence ends at "started again" and then immediately starts a new thought. Consider splitting: ``` mark, and stays paused when the route starts, also when the same route is stopped and started again. A pre-configured trigger that you reuse with the Camel URI is resumed ``` ########## components/camel-quartz/src/test/resources/org/apache/camel/component/quartz/SpringQuartzPersistentStorePauseJobRestartTest.xml: ########## @@ -0,0 +1,74 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<beans xmlns="http://www.springframework.org/schema/beans"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns:jdbc="http://www.springframework.org/schema/jdbc"; + xsi:schemaLocation=" + http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd + http://www.springframework.org/schema/jdbc http://www.springframework.org/schema/jdbc/spring-jdbc.xsd + http://camel.apache.org/schema/spring http://camel.apache.org/schema/spring/camel-spring.xsd + "> + + <!-- the persistent store for quartz --> + <jdbc:embedded-database id="{{testClassSimpleName}}" database-name="{{runName}}" type="H2"> + <!-- do not load script as database alreaady exists --> Review Comment: Nit: `alreaady` → `already`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
