Croway commented on PR #28683: URL: https://github.com/apache/camel/pull/28683#issuecomment-6497342110
_Claude Code on behalf of Croway_ Thanks for the review. Done in 2f9d51c400dd: - **headers / variables as `Object`:** a JSON object sent for them now has its JSON held to the same `camel.mcp.security.max-argument-length` as the string arguments (`AuthoringTools.limited` in the MCP wrapper). A string sent for these arguments was already checked by `McpSecurityInterceptor`, which tests the runtime type. - **`Boolean.valueOf(predicate)`:** `predicate` other than `true` / `false` (case insensitive) is now refused (`predicate is true or false, not yes`) instead of being taken for false. - **Conflict with #28678:** rebased on main after #28678 and #28679 merged, keeping this PR's `evaluateWith` signature with the `withoutCliConnector` wrapper. With the rebase I also added one thing: the elvis rewrite of CAMEL-26401 now goes with the tool error of an integration before 4.24, where a failed eval action is a tool error and the rewrite never reached the model (see the update at the end of the description). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
