Croway commented on PR #28682: URL: https://github.com/apache/camel/pull/28682#issuecomment-6497025799
_Claude Code on behalf of Croway_ Thanks for the review. - **Upgrade guide for the NAME change:** `camel stop <name>` (and the other process commands) go through `ProcessFinder.find`, whose `matches` takes the displayed name *or* the Camel context name (`ProcessFinder.java:183-197`). So `camel stop <context-name>` keeps matching on Linux after this change. Only the NAME column of `camel ps` changes, to the route-file name, as it always was on macOS. Because nothing users rely on stops working, I left the upgrade guide out. - **`isCut` counts characters:** right, the JDK cuts at a page of bytes. It only matters when `/proc/<pid>/cmdline` cannot be read (another user, `hidepid`) and the command line has multi-byte characters. I'll fix it in the follow-up for the same bug in the TUI (`ProcessControl` restart, `StatusParser`, `ProcessTab` also read the cut command line). - **`COMMANDS` keyed by the launched pid:** yes, intended. When a launcher runs `java` as a child instead of `exec`, the integration's pid is not in the map, so the lookup falls back to `/proc/<pid>/cmdline`, which has the whole command line on Linux. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
