davsclaus commented on PR #28675: URL: https://github.com/apache/camel/pull/28675#issuecomment-6497050751
_Claude Code on behalf of davsclaus_ Thanks @oscerd. - **`Exporter extends ExportRequest`**: agreed that composition reads cleaner. It is inheritance here because the exporters are a `git mv` of the old `ExportBaseCommand` subclasses, whose options were their own fields: they use the 55 request fields directly in about 1000 places. Changing that in this PR would bury the move in a rewrite, so we'll do it as a separate mechanical PR once the CAMEL-24727 stack has landed. Each exporter already works on its own shallow copy of the request (`ProjectExporter.export` copies it), so the caller's request is not changed by the export. - **Full suite**: yes. Locally the export tests (`ExportTest` and the rest of camel-jbang-core, 2657 tests) pass on this branch. The full CI will run when this retargets to `main` after #28671, and we will check it is green before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
