allthingssecurity commented on PR #28716: URL: https://github.com/apache/camel/pull/28716#issuecomment-6517188088
@davsclaus thanks for the review. Where each suggestion goes: 1. `route=`, `at=poll` and `corrupt` come with 3b, so the generic "a rule needs a target" message goes away there. Until then 3a could name them as coming in the next stage, for example "route= is not supported yet, it comes with the next stage; use endpoint=, component= or step=". Do you want that interim message in 3a now, or should 3a stay as it is? 2. Two report entries with the same id after `changeRule`: 3b adds a version number per entry, before the CLI/MCP PR keys by id. 3. `endpoint=*` also matching the send to the dead letter channel, and `step=*` the steps inside `onException`/`doCatch`: a note under "Where the faults are raised" in the 3b docs. 4. A WARN in camel-main when `camel.chaos.*` is set without the camel-chaos JAR: in 3b or in PR 4 (CLI/MCP). 5. Dropping ended rules at the next update and precomputing the pattern for `matchesUri`: in 3b. 6. `ChaosStressTest.awaitSends`: moves to `await().atMost(...)` in 3b. In the CLI/MCP PR, `chaos_add` and `chaos_change` stay `destructiveHint=true` and in `ToolConfirms`. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
