gnodet-bot commented on code in PR #28736:
URL: https://github.com/apache/camel/pull/28736#discussion_r4426620358
##########
test-infra/camel-test-infra-artemis/src/main/java/org/apache/camel/test/infra/artemis/services/AbstractArtemisEmbeddedService.java:
##########
@@ -158,7 +158,13 @@ public String password() {
@Override
public void restart() {
-
+ try {
+ getEmbeddedBrokerService().getActiveMQServer().stop(false);
+ getEmbeddedBrokerService().getActiveMQServer().start();
Review Comment:
⚠️ **Missing activation wait after `start()`**
`initialize()` calls `waitForActivation(20, TimeUnit.SECONDS)` after
`embeddedBrokerService.start()` to ensure the broker is fully active before
returning. This `restart()` method calls `start()` and returns immediately,
which may cause callers to interact with a not-yet-activated broker.
Consider adding the same `waitForActivation` call here:
```suggestion
getEmbeddedBrokerService().getActiveMQServer().start();
getEmbeddedBrokerService().waitForActivation(20,
TimeUnit.SECONDS);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
