davsclaus opened a new pull request, #28745:
URL: https://github.com/apache/camel/pull/28745

   _Claude Code on behalf of davsclaus_
   
   Fixes [CAMEL-26403](https://issues.apache.org/jira/browse/CAMEL-26403).
   
   `camel kubernetes run` created its export with `symbolicLink=true` and 
`javaLiveReload=false`, as fixed values of the 
`KubernetesExport.ExportConfigurer`, whether `--dev` was used or not. 
`KubernetesExport` set them on its fields, but nothing passed them on to the 
exporter that writes the project, so they never had an effect: the source files 
are always copied, never linked, and Java live reload is always off.
   
   The issue left open whether to make them work or remove them. This PR 
removes them, which changes nothing in what `camel kubernetes run` does:
   
   - **Symbolic links** do not fit this run: the project is built into a 
container image (Jib or JKube), and links in the build context may not be 
followed. `--dev` already exports and deploys again on every change, which 
works with copied files.
   - **Java live reload** cannot work as with `camel run --dev`: the code runs 
in a pod, from the image, not in a local JVM that can reload it. It was off 
anyway.
   
   If one of them is wanted later, it is a feature of its own, on the 
`ExportRequest`, which has both fields.
   
   ## Changes
   
   - `KubernetesExport.ExportConfigurer` has no `symbolicLink` and 
`javaLiveReload` components any more, and `KubernetesRun` no longer passes them.
   - The two fields of `ExportBaseCommand` that only held these values are 
removed.
   
   ## Tests
   
   - camel-jbang-plugin-kubernetes: 156 tests pass.
   - camel-jbang-core compiles. No test covered the two values, as they had no 
effect.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_0128ThHB3iQdrvSRLVBGRrdP
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to