allthingssecurity commented on PR #28756: URL: https://github.com/apache/camel/pull/28756#issuecomment-6540698184
@davsclaus thanks for the review. In f972e99: - Upgrade guide: a short entry in `camel-4x-upgrade-guide-4_24.adoc`. The second and later doFinally steps now run and send, and a failing route called from such a doFinally is handled or continued by its own error handler. - `RoutingSlipInDoFinallyAfterRecipientListTest`: I dropped `routingSlipAfterRedeliveryDoesNotUseTheRecipientListValue`, together with its model-class helpers. The three other bug tests of the class cover the same root cause, the recipient list's value left for the routing slip, and they assert the `mock:dead` count and each destination explicitly. The PR description is updated. - `FinallyProcessor`: two one-line comments, one on the primitive "set and true" snapshot vs the nullable `Boolean` of `OnCompletionProcessor`, one on the one-way restore of `failureHandled`. Side question: it reproduces on main (baaf532). The doTry calls a route that fails unhandled, and the doCatch then calls a route with a dead letter channel, or with a handled `onException`, that fails. That route's error handler does not run (`mock:dead` / `mock:handled` 0), and the exchange fails with its exception, still `failureHandled=true` / `errorHandlerHandled=false`. When the doTry fails in the same route, the same called route handles it. I have drafted a follow-up JIRA and will link it here once it is filed. The doTry/doCatch/doFinally, routing slip, recipient list and onCompletion tests pass (408 tests). _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
