allthingssecurity commented on PR #28786: URL: https://github.com/apache/camel/pull/28786#issuecomment-6555717882
Thanks for the review. Fixes are in a95c66f. The branch now includes main (merge commits bdef13d and baedff3, no rebase). 1. Main (with #28756) is merged into the branch, and the promised test is in: `doFinallyWithTwoStepsAfterDoCatchCalledRouteHandledItsFailure`, plus its in-route control. The route called from the `doCatch` handles its failure, both `doFinally` steps run, and the caller stops after the `doTry`. With the `CatchProcessor` of main the test fails: the exchange fails with the called route's exception. 2. The follow-up JIRA is drafted and will be linked from CAMEL-26434 shortly. It includes your nested `direct:inner` case, which I reproduced on the merged tree with a scratch test. Via the callee the outer DLC gets nothing and the exchange fails with the `doCatch`'s `IllegalStateException`. In the in-route control the outer DLC gets the message. The PR description lists this case under the follow-up. 3. The upgrade guide entry is now a lead paragraph plus a bullet list of the other effects, then the way back. 4. The `CatchProcessor` comment now says that no known case reaches the restore of a `true` mark, and that it is kept for symmetry with `FinallyProcessor`. I also checked a handled `onException` in the callee whose handler throws: it does not reach that branch either. 5. The async test now asserts `assertNotEquals(startThread, ...)` (plus `assertNotNull`) instead of matching the "Delay" thread name. Tests: the class now has 23 tests, and 14 of them fail with the `CatchProcessor` of main. 20 runs in one JVM: 460 tests. On the tree merged with main 0c2d477, the `org.apache.camel.processor.**` tests and the doTry/redelivery/error handler/exception tests of `org.apache.camel.issues` gave 2980 tests, 0 failures. After the review commit and the merge of f901a8c: the doTry/doCatch/doFinally and split tests of camel-core, 410 tests, 0 failures. The description is updated. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
