allthingssecurity commented on PR #28806: URL: https://github.com/apache/camel/pull/28806#issuecomment-6566998396
Thanks @gnodet-bot, fixed in 32510d202fe7 as suggested (review comment on `TraceProcessorsInterceptStrategy.java:97`). - A failure to end the processor span is set on the exchange only when the exchange has no exception. Otherwise the original exception is kept and the failure is logged at WARN with the processor name. - New `ProcessorSpanEndFailureTest` (MockTracer whose `endProcessorSpan` throws): with a step that sets an exception, that exception is kept (this test fails without the commit); with no exception on the exchange, the end failure is still set. The WARN line shows in the module's test log; the module's tests don't assert on logs, so the test doesn't either. - camel-telemetry module tests pass (182), as do camel-opentelemetry2 (41), camel-telemetry-dev (14) and camel-micrometer-observability (20), with `ProcessorSpanBeginFailureTest` unchanged. The new test with `ProcessorSpanBeginFailureTest`, 20 times in one JVM: 60/60. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
