allthingssecurity commented on PR #28812: URL: https://github.com/apache/camel/pull/28812#issuecomment-6571525494
Thanks for the review. Pushed in 22494ea (main merged in, no rebase): - **`camel get chaos --json`** now copies the `lifecycle` object, and `ChaosDevConsole.RuleEntry` has metadata for it. The generated `chaos.json`, its catalog copy and `dev-consoles-openapi.json` are updated. Tests: `ListChaosTest.lifecycleRuleAsJson` and `ChaosDevConsoleTest.aLifecycleRuleHasItsLifecycle`. - **"Order of work":** step 3 is marked done. - **State value:** `coming back` is now `comingBack`, in the code and both doc copies. - **`scheduleComeback`:** chaos now sets its own `stopping` flag in `contextStopping()` (from its `onContextStopping`), and `isContextStopping()` checks it as well. An action that finishes while the context stops therefore always ends `cancelled` with "the CamelContext is stopping". `aContextStopWhileTheRuleActsCancelsTheFault` already asserts that reason, and it passed 20 runs. - **Line break:** the JSON paragraph in "Route lifecycle faults" is reflowed. - **"Time and the seed":** this describes the DST behaviour of step 8. That PR (the DST world, `ChaosLifecycleDstTest`) follows as soon as this one merges. Its commit still applies cleanly on top of this branch. Tests: camel-chaos 313 and `ListChaosTest` 9 pass. `ChaosLifecycleTest`, `ChaosDevConsoleTest` and `ListChaosTest` passed 20 runs each, each run in its own JVM. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
