apupier commented on code in PR #28838:
URL: https://github.com/apache/camel/pull/28838#discussion_r4440496466
##########
components/camel-ai/camel-docling/src/test/java/org/apache/camel/component/docling/DoclingInputSourceValidationTest.java:
##########
@@ -209,13 +209,17 @@ void batchStringBodyIsRejectedByDefault() {
@Test
void batchTypedPathListIsNotGated() throws Exception {
- Path input = Files.writeString(tempDir.resolve("batch-input.txt"),
"hello");
- // an explicit List<String> of paths cannot be mistaken for document
content, so it needs no opt-in
- assertThatThrownBy(() -> template.requestBody("direct:batch",
List.of(input.toString())))
- .isInstanceOf(CamelExecutionException.class)
- .cause()
- .isNotInstanceOf(IllegalArgumentException.class);
+ // Skip this assertion on ppc64le because batch path-list handling
behaves differently on this architecture.
+ if (!"ppc64le".equals(System.getProperty("os.arch"))) {
Review Comment:
we should not skip the assertion with a condition but use an annotation to
skip the test on this architecture. it allows to make it visible that this use
case is not working on a specific architecture , otherwise the test appaears as
passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
