apupier opened a new pull request, #28851: URL: https://github.com/apache/camel/pull/28851
All tests of CassandraKeyValueRepositoryIT used the same literal keys (key1, key2, ...) in the shared camel_ks.camel_keyvalue table, and @AfterEach truncated the whole table. Cassandra truncation is not instantaneous, so a TRUNCATE from one test could interfere with the writes of the next one, leading to random failures such as: - testReplaceWithTtl: expected <value2> but was <value1> - testReplaceMatchingOldValue: expected <value2> but was <value1> - testDeleteWithExpectedValueMatching: expected <null> but was <value1> Fix by isolating the tests from each other: - each test uses its own unique keys, by prefixing them with a random UUID through a key() helper, and the shared table is no longer truncated in @AfterEach - testKeys, testClear and testSize rely on the whole content of the repository, which cannot be isolated with unique keys, so they now use a repository backed by a dedicated table created for the test (camel_kv_<uuid>) The other *KeyValueRepositoryIT (Redis, Infinispan, Kafka) were checked and do not need this fix, as their clear() operation is applied synchronously (or ordered in the changelog topic for Kafka) before the next test starts. Co-authored-by: IBM Bob 2.2.1 # Description <!-- - Write a pull request description that is detailed enough to understand what the pull request does, how, and why. --> # Target - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> # AI-assisted contributions - [ ] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
